Repository navigation
Conversation
The speaker and jack echo reference configurations always add a route from alh-copier.Loopback_Virtual.25 to the echo reference siggen, but cavs-sdw.conf defines that DAI copier only with SDW_ECHO_REF_DAI=true. sof-sdca-amp-ref is built with SDW_SPK_ECHO_REF=true and the default SDW_ECHO_REF_DAI=false, so it contains a route from a widget that no topology defines, and the kernel fails loading it in sof_route_load(): error: G001 route 'alh-copier.Loopback_Virtual.25' -> 'siggen.120.1': source widget 'alh-copier.Loopback_Virtual.25' does not exist (kernel: snd_soc_dapm_add_routes, sof_route_load) Add the loopback route only with SDW_ECHO_REF_DAI=true. The jack echo reference has the same problem, although no current target uses it without the loopback DAI. Topologies built with SDW_ECHO_REF_DAI=true are unchanged apart from the order of routes. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
bardliao and
ujfalusi
and
a balanced review from Copilot
October 26, 2026 15:25
Collaborator
Author
|
Found with the new tplg2 validator tool #11344 |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
What changed in this PR
Conditionally adds the echo reference loopback route only when the loopback DAI copier is actually defined (SDW_ECHO_REF_DAI=true), preventing kernel topology load failures due to missing source widgets.
Changes:
- Gate the
alh-copier.Loopback_Virtual.25 -> siggen.*route behindIncludeByKey.SDW_ECHO_REF_DAI { "true" { ... } }for both speaker and jack echo reference configurations.
| File | Description |
|---|---|
| tools/topology/topology2/platform/intel/sdw-jack-echo-ref.conf | Wraps the loopback echo-ref route in an SDW_ECHO_REF_DAI conditional to avoid referencing an undefined DAI copier. |
| tools/topology/topology2/platform/intel/sdw-amp-echo-ref.conf | Same conditional gating for speaker echo reference to prevent missing-widget route errors when the loopback DAI isn’t present. |
Review effort: Lite
Copilot stopped reviewing on behalf of
kv2019i due to an error
October 26, 2026 15:59
PR 11359: test resultsRun date: 2026-10-26 16:58 UTC Tested commit: da6c8e47a8f189c38a9228a7feba6b093403d144
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The speaker and jack echo reference configurations always add a route from alh-copier.Loopback_Virtual.25 to the echo reference siggen, but cavs-sdw.conf defines that DAI copier only with SDW_ECHO_REF_DAI=true.
sof-sdca-amp-ref is built with SDW_SPK_ECHO_REF=true and the default SDW_ECHO_REF_DAI=false, so it contains a route from a widget that no topology defines, and the kernel fails loading it in sof_route_load():
error: G001 route 'alh-copier.Loopback_Virtual.25' -> 'siggen.120.1':
source widget 'alh-copier.Loopback_Virtual.25' does not exist
(kernel: snd_soc_dapm_add_routes, sof_route_load)
Add the loopback route only with SDW_ECHO_REF_DAI=true. The jack echo reference has the same problem, although no current target uses it without the loopback DAI. Topologies built with SDW_ECHO_REF_DAI=true are unchanged apart from the order of routes.