Repository navigation
Conversation
This reverts commit 4db5285.
There was a problem hiding this comment.
🟡 Changes recommended
Removing hda_codec_stop_cmd_io() can leave RIRB DMA active when ring buffers are freed after firmware probing fails, reintroducing a critical DMA-after-free that can cause IOMMU faults or memory corruption.
1 open issue
What changed in this PR
This PR reverts #5976 in the Intel SOF audio driver, removing the explicit command-DMA shutdown added to controller teardown.
Changes:
- Removes
hda_codec_stop_cmd_io()fromhda_dsp_remove(). - Removes the accompanying comment about stopping CORB/RIRB DMA before freeing ring buffers.
| File | Description |
|---|---|
sound/soc/sof/intel/hda.c |
Reverts the explicit CORB/RIRB DMA stop during device removal. |
Review effort: Balanced
| /* stop CORB/RIRB DMA before the ring buffers are freed below */ | ||
| hda_codec_stop_cmd_io(sdev); | ||
|
|
||
| free_irq(sdev->ipc_irq, sdev); |
Collaborator
Author
|
reverting in favor of the upstream proposed, broader fix: https://lore.kernel.org/linux-sound/20261028144446.992948-1-sashal@kernel.org/ |
bardliao
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5976