Repository navigation
Port fluent-ribbon to the vendored upstream gpui (WI-1427) - #13
Open
thedancingdeveloper wants to merge 1 commit into
Open
thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
WI-1427. Every gpui symbol the crate uses is in the drift report's unchanged set, and cargo check, test and clippy --no-deps -D warnings pass with no edits, so the public API is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #12 (
wi-1426-port-fluent-primitives). Do not merge until #12 lands; this PR's base is that branch, notgpui-upstream.Ports
crates/fluent-ribbonto the vendored zed gpui. No source change was required. WI-1350's drift report lists everygpuisymbol the crate uses (App,AnyElement,ClickEvent,Context,FontWeight,IntoElement,Render,SharedString,Window,div,prelude,px,svg) as unchanged between the base fork and the vendored snapshot, and that holds: the crate compiles, its tests pass, and clippy is clean againstvendor/zedwith no edits. This PR only records that indocs/gpui-api-drift.md.The element-scale and font pre-warm patches were not needed.
Public API
No breaking changes.
fluent-ribbon's public API is untouched, so the crates that build on it can port against it as-is.Operator check
None. This is a compile-level port; nothing here needs a visual check.
Gates (Linux)
cargo check -p fluent-ribbon— cleancargo test -p fluent-ribbon— 0 passed, 0 failed (the crate has no unit tests; its one doc-test is ignored)cargo clippy -p fluent-ribbon --all-targets --no-deps -- -D warnings— clean.--no-depsbecause the vendoredztracingcrate fails-D warningson its ownunexpected_cfglint, which is outside this crate.WI-1427.