Skip to content

fix(cli): show what the server answered when an assertion fails - #60

Merged
moosebay merged 1 commit into
mainfrom
fix/cli-failure-output
Oct 7, 2026
Merged

moosebay merged 1 commit into
mainfrom
fix/cli-failure-output

Conversation

@moosebay

@moosebay moosebay commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

A failing flow printed the same error four times, then the whole flag reference, and never said what came back. It now prints one line:

Error: assertion failed: response.status == 200 (got 401: {"error":"Invalid credentials"})
  • node.AssertionError adds the status. For a non-2xx response it also adds a one-line, 200-char body excerpt. 2xx bodies are left out of CI logs, since they can carry tokens. Used by the request and GraphQL nodes.
  • flow run silences cobra usage once arguments are valid; argument errors still print usage.
  • The root command prints errors once and exits 1. The runner's duplicate error log is now debug-level.
  • Version plan: cli: patch.

Verified: new assert_error_test.go, server:test, CLI tests, server:lint, cli:lint, root:lint:format, client:lint. Also checked by hand with a built binary against a real 401.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DTfHLHkkg1TPGQgj6P6grg

A failing flow printed the same error four times followed by the whole flag
reference, and never said what came back. It now prints one line:

  Error: assertion failed: response.status == 200 (got 401: {"error":"Invalid credentials"})

- node.AssertionError adds the status, and for a non-2xx response a
  one-line body excerpt (200 chars); 2xx bodies stay out of CI logs since
  they can carry tokens. Used by the request and GraphQL nodes.
- flow run silences cobra usage once arguments are valid; argument
  errors still print it.
- The root command prints errors once and exits 1; the runner's duplicate
  error log is now debug-level.

Claude-Session: https://claude.ai/code/session_01DTfHLHkkg1TPGQgj6P6grg
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📊 Performance Comparison

Generated on 2026-10-07 15:47:36 UTC

Detailed Results

Benchmark Old Ops/sec New Ops/sec Change Memory Change Status
CreateMockFlow_Large 84278 84278 +0.0% +0.0% ⚠️
CreateMockFlow_Medium 243126 238723 -1.8% +0.0% ⚠️
CreateMockFlow_Small 557421 542948 -2.6% +0.0% ⚠️
FlowExecution_Large 46 46 +0.0% -0.1% ⚠️
FlowExecution_Medium 135 134 -0.7% -0.0% ⚠️
FlowExecution_Small 368 369 +0.3% +0.0% ⚠️

📈 Summary Statistics

  • Total benchmarks compared: 6
  • Regressions: 0 🚨
  • Improvements: 0 ✅
  • Neutral: 6 ⚠️

✅ Stable Performance: All benchmarks within acceptable range

@moosebay
moosebay merged commit 4c631bf into main Oct 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant