Repository navigation
Wait for orphan reaping in cancellation test - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blocked-output cancellation test assumed a grandchild PID disappears as soon as the wrapper exits. Main CI on macOS showed the direct Codex process was reaped while the grandchild still answered signal 0; an orphaned zombie can remain visible until the OS reaps it.
Wait for grandchild disappearance within the test's existing five-second deadline. Keep the immediate direct-child reaping assertion, cancellation exit status, and failure on persistent descendants. Runtime cancellation behavior is unchanged.
Validation: formatting and workspace Clippy, all 96 workspace tests, and 200 focused stress runs covering 400 responsive/unresponsive cases. The original timing failure did not reproduce in 80 baseline runs; a controlled zombie experiment confirmed the signal-0 distinction. Independent review found no issues.