fix: restore android release publishing - #121
Merged
Merged
Conversation
ovitrif
marked this pull request as ready for review
October 1, 2026 15:02
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
@codex review. suggest a better approach if there is one. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pwltr
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #119
Description
platform-tools, avoiding the unavailable legacytoolspackage insetup-android@v3defaults.dry_rundispatch input to build the selected release tag and upload CI debug symbols while skipping release-asset updates and Maven publication. Existing release events and manual publishing retain their behavior.Cause and history
rc68 failed when
sdkmanager toolsexited withFailed to find package 'tools', before the NDK or compilation steps. rc67 failed at the same step. rc66 succeeded on September 2 using the same setup action commit and package defaults. The SDK step was introduced in #84 and has been unchanged since June; #119 has no workflow changes. The later NDK alignment changes were not reached by the failing runs.The action's v3 defaults include
tools platform-tools; its current documentation explains that Google no longer servestoolsand command-line tools replace it. #103 updates separate bindgen workflows; this PR repairs the existing publisher.Out of Scope
QA Notes
Automated Checks
actionlint .github/workflows/publish-android.yml,cargo fmt,git diff --check.dry_run=trueandversion=v0.7.0-rc.68. The workflow came from this branch and checkout used 773792d, whose tree matches merged source. SDK setup, exact NDK28.1.13356709, three native ABI builds, bindings, Gradle/Maven-local packaging and CI debug-symbol upload all passed.Manual Tests