Skip to content

fix: restore android release publishing - #121

Merged
ovitrif merged 1 commit into
mainfrom
codex/fix-android-release-publishing
Oct 1, 2026
Merged

ovitrif merged 1 commit into
mainfrom
codex/fix-android-release-publishing

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Refs: #119

Description

  • Restore Android release setup by explicitly requesting platform-tools, avoiding the unavailable legacy tools package in setup-android@v3 defaults.
  • Add an optional dry_run dispatch input to build the selected release tag and upload CI debug symbols while skipping release-asset updates and Maven publication. Existing release events and manual publishing retain their behavior.
  • Pass the normalized version through environment variables and reject malformed version inputs.

Cause and history

rc68 failed when sdkmanager tools exited with Failed to find package 'tools', before the NDK or compilation steps. rc67 failed at the same step. rc66 succeeded on September 2 using the same setup action commit and package defaults. The SDK step was introduced in #84 and has been unchanged since June; #119 has no workflow changes. The later NDK alignment changes were not reached by the failing runs.

The action's v3 defaults include tools platform-tools; its current documentation explains that Google no longer serves tools and command-line tools replace it. #103 updates separate bindgen workflows; this PR repairs the existing publisher.

Out of Scope

  • Native libraries, APIs, bindings, version bumps and existing published artifacts.
  • Release publication validation remains a subsequent new-version operation; a dry run validates setup, compilation, packaging and artifact upload.

QA Notes

Automated Checks

  • Local verification: actionlint .github/workflows/publish-android.yml, cargo fmt, git diff --check.
  • Hosted verification: Android Publish dry run passed on 2a74e84 with dry_run=true and version=v0.7.0-rc.68. The workflow came from this branch and checkout used 773792d, whose tree matches merged source. SDK setup, exact NDK 28.1.13356709, three native ABI builds, bindings, Gradle/Maven-local packaging and CI debug-symbol upload all passed.
  • The release-symbol upload and GitHub Packages publication were verified skipped. rc68 release asset IDs, digests and modification timestamps are unchanged; its tag still points to 773792d. This is build/packaging validation, not a new publication.

Manual Tests

  • (after merge) Publish the next new version and verify release debug symbols and the Maven package from the hosted run. Existing rc68 assets and Maven coordinates must remain unchanged.

@ovitrif ovitrif self-assigned this Oct 1, 2026
@ovitrif
ovitrif marked this pull request as ready for review October 1, 2026 15:02
@chatgpt-codex-connector

This comment was marked as outdated.

ovitrif commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review. suggest a better approach if there is one.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T16:49:42.159206Z 2a74e84 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif
ovitrif requested review from ben-kaufman and pwltr October 1, 2026 16:46
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 2a74e84153

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ovitrif
ovitrif merged commit 6d24c44 into main Oct 1, 2026
1 check passed
@ovitrif
ovitrif deleted the codex/fix-android-release-publishing branch October 1, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants