Skip to content

feat(trezor): upgrade to trezor-connect-rs 10.0.0 - #162

Merged
ovitrif merged 1 commit into
masterfrom
feat/trezor-10
Oct 2, 2026
Merged

ovitrif merged 1 commit into
masterfrom
feat/trezor-10

Conversation

@coreyphillips

Copy link
Copy Markdown
Collaborator

Refs #161.

Description

Upgrade both platform dependency declarations to the published trezor-connect-rs 10.0.0 release, preserving desktop/Android USB and Bluetooth, iOS Bluetooth-only configuration, and PSBT support.

  • Expose xpub_segwit, descriptor, and displayable_public_key, and document the normalized xpub/tpub contract and account-type migration. Existing stored SLIP-132 keys continue to derive the same descriptors and addresses.
  • Add false-by-default cross_chain options to address, public-key, and message-signing requests. Preserve path-based network inference, Signet's firmware Testnet mapping, and Core's Bitcoin defaults for message verification and PSBT conversion.
  • Map upstream unknown-coin and invalid-parameter errors with useful diagnostics. Preserve cancellation, authentication callbacks, transport handling, and unsupported-input restrictions.
  • Add scripted Core-manager regressions for network inference, overrides, all six key prefixes, Taproot display, direct signing, PSBT signing, and change-key network consistency. Add wallet-import equivalence checks and Swift/Kotlin/Python binding smoke fixtures.
  • Prepare Core 0.7.0 with synchronized version metadata, regenerated Swift interfaces, the XCFramework checksum, and binding smoke checks in platform CI. Kotlin/Python generated output and Android JNI libraries remain untracked under the repository's existing policy.

QA Notes

  • cargo fmt --check, cargo clippy, and cargo clippy --locked --tests pass. Clippy reports existing repository warnings.
  • cargo test --locked --lib modules::trezor: 72 passed, including the existing PIN/passphrase and transport adapter tests.
  • The wallet migration matrix passes for BIP-44/49/84/86 across Bitcoin, Testnet, and explicit Regtest, checking descriptors and receive/change addresses against existing imports and independently derived addresses.
  • cargo test: 611 passed, 27 ignored, and 11 Blocktank staging HTTP failures. The same 11 failures reproduce on untouched master, where the focused Blocktank suite reports 37 passed and 11 failed.
  • Desktop release build, iOS ARM64 device and simulator builds, XCFramework packaging, SwiftPM manifest validation, and Swift/Python record smoke tests pass. The iOS feature tree contains Bluetooth and PSBT with no USB feature.
  • ./build.sh android passes for ARMv7, ARM64, x86, and x86_64, including symbol validation, AAR packaging, and Maven Local publication. :lib:compileDebugUnitTestKotlin compiles the updated Kotlin consumer fixture successfully.

Binding check instructions are in tests/bindings/README.md. The Kotlin fixture checks compilation; Swift and Python smoke checks execute locally without a hardware connection.

Release follow-up

Keep #161 open for publication of the 0.7.0 platform artifacts, Android/iOS dependency and import-flow updates, and hardware smoke tests with device, firmware, transport, and test-fund details. Native consumers must preserve selected account type and stored key representation during wallet reattachment, and use the new display field for user-facing exports.

Expose normalized keys and display fields, preserve network defaults,
and add explicit path override support. Prepare Core 0.7.0 with migration
regressions and binding smoke checks.

BREAKING CHANGE: exported xpub values are normalized to xpub/tpub.
Rust request records require cross_chain, and public-key response
constructors include the new display fields.

@ovi-reviewer ovi-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ✅ Approve

Review: diff 22 files.


Reviewed by gpt-6.1-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest (author)

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif
ovitrif merged commit d4f60ae into master Oct 2, 2026
6 checks passed
@ovitrif
ovitrif deleted the feat/trezor-10 branch October 2, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants