feat(trezor): upgrade to trezor-connect-rs 10.0.0 - #162
Merged
Merged
Conversation
Expose normalized keys and display fields, preserve network defaults, and add explicit path override support. Prepare Core 0.7.0 with migration regressions and binding smoke checks. BREAKING CHANGE: exported xpub values are normalized to xpub/tpub. Rust request records require cross_chain, and public-key response constructors include the new display fields.
There was a problem hiding this comment.
Verdict: ✅ Approve
Review: diff 22 files.
Reviewed by gpt-6.1-sol-high via gh-pr-review-loop skill
Commands: @ovi-reviewer review · test · retest (author)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #161.
Description
Upgrade both platform dependency declarations to the published
trezor-connect-rs 10.0.0release, preserving desktop/Android USB and Bluetooth, iOS Bluetooth-only configuration, and PSBT support.xpub_segwit,descriptor, anddisplayable_public_key, and document the normalizedxpub/tpubcontract and account-type migration. Existing stored SLIP-132 keys continue to derive the same descriptors and addresses.cross_chainoptions to address, public-key, and message-signing requests. Preserve path-based network inference, Signet's firmware Testnet mapping, and Core's Bitcoin defaults for message verification and PSBT conversion.QA Notes
cargo fmt --check,cargo clippy, andcargo clippy --locked --testspass. Clippy reports existing repository warnings.cargo test --locked --lib modules::trezor: 72 passed, including the existing PIN/passphrase and transport adapter tests.cargo test: 611 passed, 27 ignored, and 11 Blocktank staging HTTP failures. The same 11 failures reproduce on untouched master, where the focused Blocktank suite reports 37 passed and 11 failed../build.sh androidpasses for ARMv7, ARM64, x86, and x86_64, including symbol validation, AAR packaging, and Maven Local publication.:lib:compileDebugUnitTestKotlincompiles the updated Kotlin consumer fixture successfully.Binding check instructions are in
tests/bindings/README.md. The Kotlin fixture checks compilation; Swift and Python smoke checks execute locally without a hardware connection.Release follow-up
Keep #161 open for publication of the 0.7.0 platform artifacts, Android/iOS dependency and import-flow updates, and hardware smoke tests with device, firmware, transport, and test-fund details. Native consumers must preserve selected account type and stored key representation during wallet reattachment, and use the new display field for user-facing exports.