Conversation
2 tasks
…t/allowance-auto-accept
…t/allowance-auto-accept # Conflicts: # app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
…t/allowance-auto-accept
Collaborator
Author
|
Pushed 528fb7b: merged the updated
|
Collaborator
Author
|
Added the device result and media to the description.
|
…t/allowance-auto-accept
Collaborator
Author
|
Pushed e7a8bd3: merged the updated
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1353
Twin: synonymdev/bitkit-ios#841
Stacked on #1340
Refs: #1351
This PR makes the allowee's wallet accept an allowance the allower offers, so the allowee taps nothing and the allowance is active as soon as the offer arrives.
Description
Out of Scope
Design
N/A — no design available.
Preview
allowance-set-and-accept-payer-left-payee-right.mp4
QA Notes
Journeys
set-and-accept.xml— the allowee's wallet accepts the offer with no review sheet, posts "Allowance Added", and both rows turn Activea3861cebuild, Paykit rc59: the allowee accepted once with no tap, no review sheet opened, "Allowance Added" posted once, and both rows turned Active. The allowee's row took about 3 min 16 s after Save on a heavily loaded host, 2 min of it the payer publishing the proposal.SkipIntrotag (its "Skip Intro" text works), and Choose Contact shows "Add a contact first" for about 3 minutes after the contacts are saved, until Paykit discovery finishes.Manual Tests
N/A
Automated Checks
PaykitAllowanceTest.kt— only a received proposal from the allower counts as an offerPaykitAllowanceRepoTest.kt— an allower's offer is accepted without the sheet and not announced twice; a failed accept is retried; an allowee's ask still goes to the sheet; sent and answered proposals are never acceptedAppViewModelSendFlowTest.kt— the send flow stubs the new acceptance call./gradlew assembleDevDebug testDevDebugUnitTest detekton Paykit0.1.0-rc59merged with feat: add allowances for automatic paykit payments #1340 (b929cce) — 3,227 unit tests pass and detekt is clean