Skip to content

[BUG][MVP] Remove Provider-owned Profile claims from the author API and runtime #53

Closed

Description

@Noam-Alum

Prerequisite

Land the updated SFP contract from stateforge-org/stateforge-protocol#56 before implementing this consumer change. Coordinate integration verification with Agent stateforge-org/stateforge-agent#41.

Problem

Provider Python exposes @operation(..., implements=(...)), stores Profile claims in declarations, publishes them through the manifest, and checks required Profile membership during admission. These responsibilities do not belong to Providers.

Providers supply concrete Operations and Triggers with accurate schemas and implementations. The Control Plane owns Profiles, schema-based matching, field mappings, Contracts, and fulfillment. Users must be able to create Profiles and match existing Providers without changing or redeploying Provider code.

Required changes

  • Remove the public implements argument from operation, its declaration metadata and bound models, and all Profile-only validation.
  • Stop constructing manifest implements fields and consume the updated canonical SFP declaration containing input/result schemas.
  • Remove admission checks involving required_implementation_roles and Profile-claim membership. Preserve every unrelated admission guard, including session/generation fences, manifest revision, declaration existence, readiness, dynamic requirements, payload validation, deadlines, capacity, and idempotency.
  • Audit operation binding, canonical request/fingerprint handling, lifecycle/recovery, examples, fixtures, CI verifiers, and declaration/authoring documentation for removed-field assumptions.
  • Keep deriving operation request/result schemas and trigger payload schemas from their typed models. Keep validation of actual inputs, successful results, and trigger events against those schemas.
  • Preserve canonical schema semantics, including requiredness and defaults. A schema default annotation must not silently become runtime default materialization or permission to accept invalid requests.
  • Explain that schemas describe the concrete implementation. Future Control Plane matching can automatically map matching names with compatible types/constraints, suggest mappings for differing names, and keep partial matches discoverable. Provider code must not implement that matching or expose a replacement Profile registry/claim API.
  • Update Protocol dependency/build references using the repository's established dependency flow so tests run against the updated canonical contract.

This is the first release under development. Remove the obsolete API directly without deprecated aliases, ignored keyword arguments, migrations, or compatibility shims.

Acceptance criteria

  • The public operation API and runtime declarations no longer expose or publish Profile claims. Passing the removed implements keyword fails clearly rather than being silently ignored.
  • Manifest construction and real SFP exchanges use the new canonical message shape; no new Trigger claim mechanism is introduced.
  • Tests retain coverage for nested request/result/event schemas and reject invalid actual values, while proving valid concrete operations execute without Profile metadata.
  • Admission security, dynamic requirement checks, idempotency, lifecycle result validation, and recovery regressions pass without claim-membership checks.
  • Built Provider artifacts work with the updated Protocol wheel. Real installed-Agent RPM integration runs once Agent [TASK][MVP] Implement Operation Admission and Idempotency #41 is available, through supported Agent APIs and the real Provider service. Do not use a fake Agent or claim SF-AOP/daemon ingress coverage that does not exist.
  • Formatting, lint, strict typing, docs, unit/service tests, packaging, and applicable installed-runtime CI checks pass. Pending cross-repository integration is reported explicitly rather than treated as complete.
  • Final audit finds no obsolete public claim argument, claim metadata, removed protobuf references, or Profile-fulfillment assertions in active code/docs/fixtures.

Non-goals

No Profile-conformance engine, Control Plane matching/mapping implementation, Contract fulfillment, SF-AOP design, vendor integration, or schema-default behavior redesign.

Sources

  • src/stateforge_provider/declarations.py
  • src/stateforge_provider/_services/manifest/declaration.py
  • src/stateforge_provider/_services/operation_admission/
  • src/stateforge_provider/_services/operation_lifecycle/

Activity

  1. self-assigned this
    on Nov 9, 2026
  2. changed the title [-][BUG][MVP] Reject operation profile claims that do not satisfy their input and output contracts[/-] [+][BUG][MVP] Remove Provider-owned Profile claims from the author API and runtime[/+] on Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions