[6.x] Fix relationship select field crashing when switching localizations - #15485
Open
duncanmcclean wants to merge 2 commits into
Open
duncanmcclean wants to merge 2 commits into
duncanmcclean wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where switching an entry to another localization threw
TypeError: this.options is not iterablein relationship fields using the select UI (users,termswithmode: select, etc).This was happening because the select field's shared options cache is keyed by the site. When the site changes, the cache key changes too, and the watcher that copies cached options into the component ran before anything had been cached for the new key, so it replaced the options with
undefined.This PR fixes it by only copying options out of the cache once they've actually finished loading for the current key.
Fixes #15484
Caused by #13514