Repository navigation
Conversation
Author
|
Needs proper testing to make sure this is backported correctly |
When autodetect deploy interface is asked to perform a step-based-flow, such as cleaning, before it's performed a successful deployment, it hasn't delegated to a functional deploy interface yet and silently noops the action. Instead, we now explicitly ensure we are switching to a concrete interface before running step-based-flows, and also we have enhanced the autodetect deploy interface to fail loudly if any of it's non-existent concrete method implementations are called. Additionally, we explicitly unset original_deploy_interface when an API call comes in explicitly changing deploy interface. Before, we would silently switch back to the original deploy interface (likely autodetect) if a node had it's deploy interface changed via API while ACTIVE (and some other states, too). Assisted-by: Claude Code (Opus) Closes-Bug: #2163017 Change-Id: Id96e9e04ca9024e3e1b82139de66439c62e7a861 Signed-off-by: Jed Preist <jed@stackhpc.com> Signed-off-by: Jay Faulkner <jay@jvf.cc> (cherry picked from commit 3df2664)
TBExtent
force-pushed
the
backport-autodetect-clean-fix
branch
from
October 9, 2026 15:39
78fa8bd to
6b50a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When autodetect deploy interface is asked to perform a step-based-flow, such as cleaning, before it's performed a successful deployment, it hasn't delegated to a functional deploy interface yet and silently noops the action.
Instead, we now explicitly ensure we are switching to a concrete interface before running step-based-flows, and also we have enhanced the autodetect deploy interface to fail loudly if any of it's non-existent concrete method implementations are called.
Additionally, we explicitly unset original_deploy_interface when an API call comes in explicitly changing deploy interface. Before, we would silently switch back to the original deploy interface (likely autodetect) if a node had it's deploy interface changed via API while ACTIVE (and some other states, too).
Backport of 1000074: Make AutoDetectDeploy act more consistently | https://review.opendev.org/c/openstack/ironic/+/1000074