Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two corrections to
docs/RELEASING.md:NPM_TOKENrepository secret still exists. The sentence now says the workflow needs no npm token, which stays true whether or not the secret is removed after the first trusted publishing release.CHANGELOG.mdfrom commit titles, and the GitHub Release uses generated notes, so neither explains a behavior change. The next release includes one: visits tagged only with the new Google parameters from feat: capture GA4 campaign parameters and Google click IDs used on iOS and Display & Video 360 #223 now count as campaigns and add keys to attribution payloads. The release steps now say to add a short note to the generated section for changes like that and amend the release commit before pushing.pnpm exec prettier --check docs/RELEASING.mdpasses.