Repository navigation
test: consolidate utm helper tests into one suite - #218
Merged
Merged
Conversation
Member
Author
|
Review notes before merging:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for
src/runtime/utm.tswere split betweentest/unit.test.tsandtest/unit/utm.test.ts. They now live intest/utm.test.ts, next tohistory.test.tsandstorage.test.ts, so the history, storage, and utm helpers each have one test file named after them.The suite keeps all 22 cases. The 13
getGCLIDcases become one table, and the shared fixture is a typedDataObjectinstead of a JSON string.readLocalDatanow receives its storage through the existing parameter rather than a mock assigned toglobal.localStorage, so the suite no longer depends on, or replaces, a global that newer Node versions define.This prepares the file for the upcoming change that adds more campaign parameters, which extends these helpers.
Validation:
pnpm lint --max-warnings 0,pnpm test:types, Prettier on the new file, andpnpm test(81 tests) pass.