Skip to content

chore(all): batch transitive dependency upgrades for security alerts #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fefi95 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore(all): batch transitive dependency upgrades for security alerts #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
092899e
chore(all): bump turbo to 2.x and migrate turbo.json to tasks
Oct 15, 2026
bb66439
chore(all): bump typedoc to 0.28 with matching plugins
Oct 15, 2026
113571b
chore(all): bump semantic-release to 25.x
Oct 15, 2026
d5d3dcb
chore(all): yarn dedupe
Oct 15, 2026
1bceffd
chore(all): refresh vulnerable transitive deps within existing ranges
Oct 15, 2026
f400180
chore(all): bump mocha to 12.x
Oct 15, 2026
729a4d2
test(native): type fixture with ReactElement instead of global JSX
Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/mocha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@examples/symbol-plugin": "workspace:^",
"@types/mocha": "^10.0.6",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/mocha is still ^10.0.6 (10.0.6 in the lockfile) while the runtime is now mocha 12, so the tests type-check against an older API. Could we bump it together with mocha?

"@types/node": "^24.10.1",
"mocha": "^11.8.0",
"mocha": "^12.0.3",
"ts-node": "^10.9.2",
"typescript": "^5.9.3"
}
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
"tar": "7.5.22"
},
"scripts": {
"check": "turbo check && yarn lint",
"check": "turbo run check && yarn lint",
"clean": "rimraf **/.turbo/ **/build/ **/dist/ **/node_modules/",
"build": "turbo run build",
"compile": "turbo run compile",
"docs": "turbo docs",
"docs": "turbo run docs",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"release": "turbo release --concurrency=1",
"release": "turbo run release --concurrency=1",
"test": "turbo run test"
},
"devDependencies": {
Expand All @@ -49,7 +49,7 @@
"globals": "^16.5.0",
"react-native-safe-area-context": "^5.5.2",
"rimraf": "^6.1.2",
"turbo": "^1.12.4",
"turbo": "^2.11.8",
"typescript": "^5.9.3",
"typescript-eslint": "^8.47.0"
}
Expand Down
10 changes: 5 additions & 5 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@
"@types/node": "^24.10.1",
"@types/sinon": "^17.0.3",
"all-contributors-cli": "^6.26.1",
"mocha": "^11.8.0",
"semantic-release": "^23.1.1",
"mocha": "^12.0.3",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mocha@12 requires Node ^20.19.0 || >=22.12.0, and semantic-release@25 requires ^22.14.0 || >=24.10.0. The root engines.node is still >=20, so the engines plugin lets someone on Node 20.11 / 22.0 install and then fail with a confusing error in yarn test / yarn release. CI is fine because it resolves the latest 20/22/24. Should we raise the root engines.node to ^20.19.0 || >=22.12.0?

"semantic-release": "^25.0.9",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is two majors of semantic-release (and commit-analyzer 12 → 13, @semantic-release/github → 12). Since yarn release wasn't run for real, could you double-check that the releaseRules scope negations in .releaserc.json (!core, !all, …) still match the same way under commit-analyzer 13? If not, the first release after merge could publish every package for a commit scoped to one package, or publish none.

"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"publishConfig": {
Expand Down
10 changes: 5 additions & 5 deletions packages/dom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@
"@types/react-test-renderer": "^19.1.0",
"jsdom": "^24.0.0",
"jsdom-global": "^3.0.2",
"mocha": "^11.8.0",
"mocha": "^12.0.3",

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same mocha / semantic-release / typedoc* bumps are hand-edited in core, dom, native, sinon and examples/mocha. We could hoist them to the root devDependencies so the next upgrade is a single edit and can't drift. That's fine as a follow-up and doesn't need to be in this PR.

"react": "19.2.3",
"react-dom": "19.2.3",
"react-test-renderer": "19.2.3",
"semantic-release": "^23.1.1",
"semantic-release": "^25.0.9",
"semantic-release-yarn": "^3.0.2",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"peerDependencies": {
Expand Down
10 changes: 5 additions & 5 deletions packages/native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,18 @@
"@types/react": "^19.2.0",
"@types/react-test-renderer": "^19.1.0",
"@types/sinon": "^17.0.3",
"mocha": "^11.8.0",
"mocha": "^12.0.3",
"react": "19.2.3",
"react-native": "0.84.0",
"react-native-testing-mocks": "^1.7.0",
"react-test-renderer": "19.2.3",
"semantic-release": "^23.1.1",
"semantic-release": "^25.0.9",
"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/native/test/lib/fixtures/simpleToggleText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useCallback, useState } from "react";
import { type ReactElement, useCallback, useState } from "react";
import { Button, Text, View } from "react-native";

export function SimpleToggleText(): JSX.Element {
export function SimpleToggleText(): ReactElement {
const [visible, setVisible] = useState(true);

const toggle = useCallback(() => {
Expand Down
10 changes: 5 additions & 5 deletions packages/sinon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@
"@types/mocha": "^10.0.6",
"@types/node": "^24.10.1",
"@types/sinon": "^17.0.3",
"mocha": "^11.8.0",
"semantic-release": "^23.1.1",
"mocha": "^12.0.3",
"semantic-release": "^25.0.9",
"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
"ts-node": "^10.9.2",
"typedoc": "^0.25.8",
"typedoc-plugin-markdown": "^3.17.1",
"typedoc-plugin-merge-modules": "^5.1.0",
"typedoc": "^0.28.20",
"typedoc-plugin-markdown": "^4.14.0",
"typedoc-plugin-merge-modules": "^7.0.0",
"typescript": "^5.9.3"
},
"peerDependencies": {
Expand Down
7 changes: 4 additions & 3 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://turborepo.org/schema.json",
"pipeline": {
"$schema": "https://turborepo.com/schema.json",
"tasks": {
"build": {
"dependsOn": ["^build"],
"inputs": ["src/**"],
Expand All @@ -21,7 +21,8 @@
},
"release": {
"cache": false,
"dependsOn": ["^build"]
"dependsOn": ["^build"],
"passThroughEnv": ["CI", "GITHUB_*", "GH_*", "NPM_*", "YARN_*"]

@rojasTob rojasTob Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turbo 2 runs tasks in strict env mode, so anything not listed here (or in turbo's small built-in allowlist) is removed from the task's environment. All four packages publish with publishConfig.provenance: true, and release.yml grants id-token: write for that. Provenance needs ACTIONS_ID_TOKEN_REQUEST_URL and ACTIONS_ID_TOKEN_REQUEST_TOKEN, and neither matches these globs. A dry run wouldn't catch this because nothing is published.

Suggested change
"passThroughEnv": ["CI", "GITHUB_*", "GH_*", "NPM_*", "YARN_*"]
"passThroughEnv": ["CI", "GITHUB_*", "GH_*", "NPM_*", "YARN_*", "ACTIONS_*", "RUNNER_*", "GIT_*", "SEMANTIC_RELEASE_*", "DEBUG"]

(DEBUG is so DEBUG=semantic-release:* still works for troubleshooting. Alternatively, "envMode": "loose" on just this task would avoid keeping an allowlist up to date.)

},
"test": {
"dependsOn": ["^build"],
Expand Down
Loading
Loading