Repository navigation
chore(deps): minimatch vulnerability - #185
Open
KeylaMunnoz wants to merge 3 commits into
Open
KeylaMunnoz wants to merge 3 commits into
KeylaMunnoz wants to merge 3 commits into
Conversation
This was referenced Oct 15, 2026
rojasTob
approved these changes
Oct 16, 2026
rojasTob
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Key! The resolved versions (3.1.5 / 8.0.7 / 9.0.9 / 10.2.6) cover all the patched ranges for #67, #70, #73, #74 and #75, the scoped resolution correctly moves sonarjs onto 10.2.6, and CI lint passes with it.
Two non-blocking follow-ups:
- Could we add a short note or open an issue so the eslint-plugin-sonarjs/minimatch resolution gets removed when we migrate to sonarjs v4?
- brace-expansion still has its own open alerts (#133, #141, #169–#171, #177, #178). The versions currently in the lockfile (1.1.11, 2.0.1, 2.1.4 and 5.0.9) are all still affected, so that's worth a separate PR.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot ReDoS alerts for minimatch affecting older package versions:
#67: repeated wildcards with non-matching literal.
#70, #73, and #75: matchOne() with combinatorial backtracking due to multiple GLOBSTAR segments.
#74: nested *() extglobs generating catastrophic backtracking in regex.
Changes
yarn up -R minimatch: bumps minimatch within compatible ranges of each dependent, without major bumps. Versions are now at 3.1.5, 8.0.7, 9.0.9, and 10.2.6.eslint-plugin-sonarjspinned to 3.0.7: stays on v3 and already upgrades minimatch from 9.0.5 to 10.1.2.resolutionforeslint-plugin-sonarjs/minimatchto ^10.2.3: sonarjs@3.0.7 pins minimatch exactly to 10.1.2, which remains vulnerable (<10.2.3). The resolution forces the patched version strictly for this package (resolves to 10.2.6).Why not eslint-plugin-sonarjs@4?
Tested on a temporary branch. v4.2.2 introduces 22 new lint errors:
sonarjs/argument-type.sonarjs/null-dereference.These errors are present in core, dom, and their test files. Migration to v4 can be evaluated in a separate PR.