Skip to content

perf(nifi): Minor build time improvement - #1672

Merged
NickLarsenNZ merged 5 commits into
mainfrom
docker-images-nifi-speed
Sep 25, 2026
Merged

NickLarsenNZ merged 5 commits into
mainfrom
docker-images-nifi-speed

Conversation

@NickLarsenNZ

@NickLarsenNZ NickLarsenNZ commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Add additional maven options to skip unnecessary compilation.

  • skipTests (already done, and used as inspiration)
  • maven.javadoc.skip=true (don't generate docs)
  • enforcer.skip=true (skip environmental dependency and constraint enforcement - maybe we shouldn't skip this?)

    like to know if a patch of ours breaks one of the enforcer rules

  • maven.site.skip=true (skip generating the project site)
  • T 2C (build with two threads per core. I tried 1C, but it didn't appear to help).
    Apparently this is experimental. Dropping it from this PR.

@NickLarsenNZ NickLarsenNZ self-assigned this Sep 22, 2026
@NickLarsenNZ
NickLarsenNZ force-pushed the docker-images-nifi-speed branch from 8bc4fa5 to 47d7d49 Compare September 22, 2026 13:05
lfrancke
lfrancke previously approved these changes Sep 22, 2026
@NickLarsenNZ

NickLarsenNZ commented Sep 22, 2026 •

Copy link
Copy Markdown
Member Author

Before:

sample 1 sample 2 sample 3
image image image

After:

-T 1C -T 2C
Not much of an improvement Pending
image image

@NickLarsenNZ

Copy link
Copy Markdown
Member Author

This didn't improve anything. Closing

@NickLarsenNZ

Copy link
Copy Markdown
Member Author

Reopening to at least get the two doc skips in.

Comment thread nifi/Dockerfile Outdated
@NickLarsenNZ NickLarsenNZ changed the title perf(nifi): Speed up build perf(nifi): Minor build time improvement Sep 25, 2026

@sbernauer sbernauer left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This two should be safe. We skipped Maven parallel builds (for now), as they are still experimental

@NickLarsenNZ
NickLarsenNZ added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 3a0d782 Sep 25, 2026
3 checks passed
@NickLarsenNZ
NickLarsenNZ deleted the docker-images-nifi-speed branch September 25, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants