Repository navigation
Conversation
miravoss26
left a comment
There was a problem hiding this comment.
Adds evPowerWarning so EV warnings for power_below_target, power_above_target and no_power_response show requested A, pilot A and measured power. It falls back to the old text when readings are stale or any value is missing, and the new test covers both fallbacks. Severity is untouched, as the description says.
- Security screen: nothing found. No new deps, hosts or secrets.
- Small question:
num(row.actual_w)guards a measured 0 W correctly only ifnumaccepts 0. The test with 0 W passes, so it does. - The CSS and test-harness fixes (
--alarm,URLSearchParams) are unrelated to the title but small and explained in the body.
Safe to merge from my read.
|
Related to #1975. During one reported charging interruption, the car drew 0 W while Easee continued to report a positive pilot of 7–12 A. Showing requested current, pilot current and measured power together gives that warning the context needed to distinguish it from a zero-pilot event. The cause of the interruption and the separate control-loop stall remain under investigation in #1975. |
When an EV charger underdelivers or draws no power, the warning shows the current FTW requested, the pilot current the charger signalled to the car, and the measured charging power when fresh pilot data is available.
In a recorded charging session, FTW requested 15 A while the charger signalled 12 A and measured power was 0 W. The warning now presents those three values together. Core still determines the warning severity.
A separate commit fixes three chart palette failures reproduced on the PR base. The EV cost label uses the theme's alarm colour, and the chart test supplies the browser's URLSearchParams API to its VM.
All 927 web tests passed locally, including the charging warning regressions.