Preserve payload group atomicity across block materialization - #67
Merged
Merged
Conversation
andinux
force-pushed
the
codex/block-payload-group-atomicity
branch
from
September 22, 2026 16:03
5338029 to
a78607c
Compare
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A payload group containing ordinary and block columns could be partially committed: a block-table write failure left the ordinary values and metadata applied while the block value was missing or stale.
The pre-block flush now writes pending ordinary columns without releasing the PK-group savepoint or advancing the applied-row count. The boundary stays open through block materialization and closes only at the actual PK/table/source-version boundary. A block failure rolls back the whole group, including ordinary columns, metadata, blocks and resurrection changes. The checkpoint stays unchanged, and replay succeeds once the cause is removed.
Validation
docs/internal/block-group-atomicity.mddocuments the boundary and tests.This is one of three independent follow-ups to #64, now based on
mainafter #64, #65 and #66 were squash-merged. No deployed cloud server was exercised or modified.The branch used to carry two more commits, both dropped in the rebase. One was the cloud-integration reliability commit, identical to the one merged with #65. The other only moved the block test to avoid a conflict with #65's test, and the rebase resolves that conflict directly.
Validation after the rebase
make unittestpasses (audit regressions and integration bootstrap: 0 failures). Full PostgreSQL suite withON_ERROR_STOP=on: 553 checks pass on standalone PostgreSQL 17 and 551 on Supabase (test 39's lock-contention part skips there by design). CI run 35751527541 passed on the rebased heada78607c: 37 jobs, only the release job skipped. The first attempt'spostgresql17-macos-x86_64job built fine but timed out uploading its artifact; a re-run passed.