Repository navigation
Fix main's build: drawHeaderTextBanner and its 15 callers take eTextSections - #387
Merged
gynt merged 1 commit intoNov 10, 2026
Merged
Conversation
Ghidra sync 6c1e0bd declares drawHeaderTextBanner's textGroupIndex as eTextSections (the header line from sourcehold#384). Main's definition still takes an int, and 15 of its callers pass a bare number, so these 16 files don't compile on d5d965d (C2511 for the definition, C2664 for each caller). These are sourcehold#384's versions of the 16 files, unchanged (from 1262303, db68fc5 and 85b9d29): the definition takes eTextSections, each caller names its text group with the banner's text above the call, and the own header is included first. sourcehold#384 then merges cleanly on top of this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gynt
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main d5d965d doesn't compile 16 files. The Ghidra sync 6c1e0bd declared
PencilRenderCore::drawHeaderTextBanner'stextGroupIndexaseTextSections(the header line from #384). Main's definition still takes anint(C2511), and 15 of its callers pass a bare number (C2664).This PR takes #384's versions of those 16 files, unchanged, so main builds again now. #384 merges cleanly after it; if #384 goes first, this one can be closed.
eTextSectionsand drops its cast.TEXT_SCENARIO7,TEXT_GAME_OPTIONS5,TEXT_XPLAY_WAITING_ROOM2,TEXT_MAINOPTIONS1), with the banner's text fromcr.texabove the call. The text numbers are decimal, and each file includes its own header first.Measured:
openshc-pr-checkgives no errors, andstatus_regression.pyfinds nothing lower.🤖 Generated with Claude Code