Repository navigation
Fix processSingleTimeTick after the 3a1c7f771 header sync - #374
Merged
Merged
Conversation
The Ghidra sync 3a1c7f7 moved SkirmishStatistics' yearStart .. monthEnd into the union SkirmishStatisticsTailUnion tail (as tail.tail1). processSingleTimeTick (0x0045CA20) still stored finalResults.yearEnd and monthEnd; it now names them through tail.tail1, the same offsets. No header or status line changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 8, 2026
gynt
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main (3a1c7f7) has one
.cppfile of its own that no longer compiles: the Ghidra sync 3a1c7f7 movedSkirmishStatistics'yearStart..monthEndinto the new unionSkirmishStatisticsTailUnion tail(astail.tail1), andGame/GameStateStructures/processSingleTimeTick.cppstill storesfinalResults.yearEndandfinalResults.monthEnd. This PR names them throughtail.tail1, the same offsets, and changes nothing else: no header and no status line.Game/GameStateStructures/processSingleTimeTick.cppfinalResults.yearEnd,finalResults.monthEndfinalResults.tail.tail1.yearEnd,.monthEndBuilt with the bundled MSVC1400-SP1, natively on Windows, against the Steam
Stronghold Crusader.exe(3bb0a8c1…5387ac5a): a compile of every.cppundersrc/OpenSHCon main leaves two failures, this one andUI/MenuModalComposition/setSliderParameters2.cpp, whose new signature (the slider types the sync took from #354) comes with #354. processSingleTimeTick read 100.0% in a full build just before the sync (303fe1c), and with this change quick_diff gives the same 202 instructions (ratio 0.9901, the call targets only).status_regression.pyfinds nothing below a known score.The same kind of fix as #343, #350, #368 and #372.
Other PRs: the ready #354 (which brings setSliderParameters2.cpp's new signature), and the drafts #313, #318, #321 (whose SkirmishStatistics change this sync took), #327, #328, #356, #360 and #363.
🤖 Generated with Claude Code