Skip to content

Mismatching enums: double check their meaning during a live game session #347

Open

Description

@gynt

Commands::M_MAPPER_BARRACKS_EURO (86) and M_MAPPER_BARRACKS_ARAB (87) have their names swapped (also in #344): convertBuildingTypeToCommandBuildingType maps BT_MERCENARYPOST to 86, and the original's BuildingAvailability jump table sends 86 to modal 0x75 (MMT_DISABLE_ARAB_TROOPS), whose menu items are this PR's DisableArab handler and render; 87 goes to 0x73 and the barracks. The MMT names, the menu names and this PR's names are right. aiPlaceAIVBuilding and shouldNotBuild... use both mapper names, so they are worth a look.

There may be more little mistakes, such as perhaps partial pitch and pitch reversed?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions