Skip to content

Integrate Conductor into java-slang - #95

Open
kjw142857 wants to merge 15 commits into
mainfrom
conductor
Open

kjw142857 wants to merge 15 commits into
mainfrom
conductor

Conversation

@kjw142857

Copy link
Copy Markdown
Contributor

No description provided.

@kjw142857
kjw142857 requested a review from martin-henz June 10, 2026 02:01
Comment thread .github/workflows/build-deploy.yml Fixed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a minimal JavaEvaluator and associated conductor runner infrastructure to support executing Java class files encoded as base64, along with corresponding unit tests. Feedback on the changes includes: initializing the entries array in ExceptionTable to prevent runtime errors, importing EVALUATOR directly from the evaluator module to avoid using @ts-expect-error, and addressing the unused setupJVM call in JavaEvaluator which currently acts as dead code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/jvm/exception-table.ts Outdated
Comment thread src/conductor/initialise.ts Outdated
Comment thread src/conductor/JavaEvaluator.ts Outdated
@github-actions

github-actions Bot commented Jun 10, 2026 •

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟡 Statements
70.62% (-0.01% 🔻)
8193/11602
🔴 Branches
58.98% (-0.21% 🔻)
2736/4639
🟡 Functions
68.94% (+0.04% 🔼)
1454/2109
🟡 Lines
71.53% (-0.03% 🔻)
7710/10779
Show new covered files 🐣
St.❔
File Statements Branches Functions Lines
🟢
... / referenced-classes.ts
95.45% 100% 100% 94.12%
Show files with reduced coverage 🔻
St.❔
File Statements Branches Functions Lines
🟢
... / generated-lib-info.ts
100%
75% (-25% 🔻)
100% 100%
🔴
... / lib-closure.ts
17.31% (-1.44% 🔻)
0% 0%
19.57% (-1.86% 🔻)
🟢 compiler/index.ts 100%
75% (-25% 🔻)
100% 100%
🟡
... / binary-writer.ts
77.36% (-3.89% 🔻)
38.46% (-11.54% 🔻)
70.59% (+0.89% 🔼)
78.32% (-4.62% 🔻)

Test suite run success

1193 tests passing in 70 suites.

Report generated by 🧪jest coverage report action from db20791

@martin-henz
martin-henz requested review from AaravMalani and removed request for martin-henz June 10, 2026 06:56

@AaravMalani AaravMalani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if the PR still in progress, I'm making it a draft for now in either case till some Conductor functionality is in place

Comment thread src/conductor/__tests__/JavaEvaluator.test.ts
Comment thread src/conductor/runner.ts Outdated
Comment thread src/jvm/exception-table.ts Outdated
Comment thread src/conductor/runner.ts Outdated
@AaravMalani
AaravMalani marked this pull request as draft June 13, 2026 17:16
@kjw142857
kjw142857 marked this pull request as ready for review September 30, 2026 05:13
@martin-henz

Copy link
Copy Markdown
Member

@codex review
Check if this is consistent with the latest conductor repo. Also compare with py-slang which is running successfully under conductor.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T09:01:24.126483Z 04f493f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0daa7a224d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/conductor/JavaEvaluator.ts Outdated
Comment thread src/conductor/JavaEvaluator.ts Outdated
Comment thread src/conductor/JavaEvaluator.ts Outdated
@martin-henz
martin-henz requested a review from hj235 October 1, 2026 09:18
@martin-henz

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04f493fc38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/jvm/utils/stdlib-natives.ts
Comment thread src/jvm/utils/build.ts Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants