Repository navigation
Rename pylint disabling of broad except - #886
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused lint-only update is correct and preserves runtime behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Pylint suppressions so CI recognizes the renamed broad-exception warning while preserving existing error logging behavior.
Changes:
- Replaces
broad-exceptwithbroad-exception-caught. - Scopes each suppression to its corresponding
exceptstatement.
| File | Description |
|---|---|
solarwinds_apm/uams.py |
Updates Pylint suppressions for UAMS file and API error handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tammy-baylis-swi
marked this pull request as ready for review
October 5, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylint
broad-exceptwas renamed tobroad-exception-caughtway back in version 2.16. Updates thedisableso CI/CD passes again. We want the errors to continue to log without escalating.