chore(deps): bump tonutils-go to v1.18.0 - #865
Open
duck-types wants to merge 6 commits into
Open
duck-types wants to merge 6 commits into
duck-types wants to merge 6 commits into
Conversation
duck-types
commented
Sep 22, 2026
duck-types
commented
Contributor
- bump github.com/xssnick/tonutils-go v1.14.1 -> v1.18.0
- sdk/ton/timelock_converter.go: handle BeginParse now returning (*cell.Slice, error)
- sdk/ton tests: use MustBeginParse where single-value context is needed
- sdk/ton/encoder_test.go: update expected error text (upstream now includes the offending address)
- regenerate sdk/ton mocks (tlb.BlockInfo was removed upstream; interface grew new methods)
- e2e/tests/stellar: MCMSDeploySalt was replaced by TimelockDeploySalt upstream
- transitively bump chainlink-canton (authentication pkg moved), chainlink-stellar (+ new deployment submodule), chainlink-ton/cciplib to tonutils-v1.18-compatible commits
- bump github.com/xssnick/tonutils-go v1.14.1 -> v1.18.0 - sdk/ton/timelock_converter.go: handle BeginParse now returning (*cell.Slice, error) - sdk/ton tests: use MustBeginParse where single-value context is needed - sdk/ton/encoder_test.go: update expected error text (upstream now includes the offending address) - regenerate sdk/ton mocks (tlb.BlockInfo was removed upstream; interface grew new methods) - e2e/tests/stellar: MCMSDeploySalt was replaced by TimelockDeploySalt upstream - transitively bump chainlink-canton (authentication pkg moved), chainlink-stellar (+ new deployment submodule), chainlink-ton/cciplib to tonutils-v1.18-compatible commits
…o-v1.18.0 # Conflicts: # go.mod # go.sum
duck-types
force-pushed
the
chore/bump-tonutils-go-v1.18.0
branch
from
September 22, 2026 14:45
6202172 to
cd40acf
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved e2e build failure and incorrect MCMS deployment salt remain; the encoder test also needs gofmt formatting.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates tonutils-go to v1.18.0 and adapts TON integrations, mocks, tests, and related Stellar dependencies.
Changes:
- Handle updated
BeginParsebehavior and refresh TON tests. - Regenerate mocks for upstream interface changes.
- Update dependency versions, checksums, and Stellar deployment helpers.
| File | Summary |
|---|---|
sdk/ton/timelock_converter.go |
Handles BeginParse errors. |
sdk/ton/timelock_configurer_test.go |
Updates cell parsing tests. |
sdk/ton/mocks/wallet.go |
Updates regenerated wallet mocks. |
sdk/ton/mocks/api.go |
Updates regenerated API mocks. |
sdk/ton/encoder_test.go |
Updates expected error text; nit (2 votes): formatting is not gofmt-compliant. |
sdk/ton/configurer_test.go |
Updates cell parsing tests. |
go.sum |
Refreshes dependency checksums. |
go.mod |
Updates TON and related dependencies. |
e2e/tests/stellar/deploy.go |
Critical (3 votes): an existing MCMSDeploySalt reference causes e2e builds to fail. Moderate (1 vote): TimelockDeploySalt changes the deterministic MCMS address; use an MCMS-specific salt. |
Files not reviewed (2)
- sdk/ton/mocks/api.go: Generated file
- sdk/ton/mocks/wallet.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
duck-types
force-pushed
the
chore/bump-tonutils-go-v1.18.0
branch
3 times, most recently
from
September 22, 2026 16:33
a006c03 to
0fbaddd
Compare
duck-types
marked this pull request as ready for review
September 22, 2026 16:34
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Address the dependency-module gap and stale test expectation before approval.
Review effort: Lite
Findings: None
Resolved since last review (2)
Files not reviewed (2)
- sdk/ton/mocks/api.go: Generated file
- sdk/ton/mocks/wallet.go: Generated file
The stellar bump was only needed to work around a mockery v2.53.5 type-check bug (fixed in v2.53.7, which this branch now uses). Reverting stellar restores MCMSDeploySalt, so the e2e salt call sites return to the original API. Canton stays bumped: new cldf (required for tonutils v1.18) removed the cldf authentication package that old canton's testhelpers import.
With chainlink-stellar reverted, the e2e salt call sites work with the original API again - no test changes needed at all.
go mod tidy had bumped it to fa1a268dac47 which is 3 commits behind ccip main, failing the go-mod-validator check. Re-pinned to 517a12a4220e (current main).
duck-types
force-pushed
the
chore/bump-tonutils-go-v1.18.0
branch
from
September 22, 2026 16:53
0fbaddd to
cffc4fd
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical dependency issue leaves the Stellar deployment module and related API updates incomplete.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Files not reviewed (2)
- sdk/ton/mocks/api.go: Generated file
- sdk/ton/mocks/wallet.go: Generated file
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.