Conversation
The delta was read from a nonexistent volumeDelta field, so .get(..., 0)
handed every adjustVolume callback a 0 and reported 0 back. The server's
updateDevice() stores an adjustVolume response's value.volume as the device's
absolute level, so "turn it down a bit" silently muted the device in the cloud
state with no error anywhere.
The delta now comes from the request's volume field, and on_adjust_volume can
return {"success": True, "volume": <new volume>} to report the level after the
adjustment. Returning True keeps the previous delta echo.
Bumps to 6.1.0; 6.0.0 is already on PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix read from a nonexistent volumeDelta field