Skip to content

fix(chat): clarify activity spacing and unify overflow fades - #8271

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/chat-card-spacing
Sep 24, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/chat-card-spacing

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Give prose and interaction cards 16px separation from activity, while keeping consecutive tool rows 8px apart. Preserve spacing when cards are answered or dismissed.
  • Keep activity text the same 15px size as response text with existing muted colors, and remove trailing dots from Thinking.
  • Reuse OverflowText's 16px fade size for expanded activity, search results, and tables through the existing scroll-fade component.

Type of Change

  • Bug fix

Testing

  • Manually verified light/dark themes, narrow layouts, answered/dismissed cards, nested activity, and top/middle/bottom scroll fades.
  • All 766 message-content tests passed, including eight new render-level regressions for activity adjacency, card states, preserved tool nodes, and terminal actions. Fade coverage also passed: 276 consumer tests and 19 primitive tests.
  • Type-check and lint-check passed across 26 workspaces; all 49 audits and generated-artifact checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 24, 2026 9:21pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 21 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding findings or new actionable defects were identified.

Summary

The PR adjusts chat activity and card spacing, standardizes overflow-fade sizing, and removes the trailing dots from “Thinking.” Changes since the previous review add render-level spacing tests, SSE idle recovery, and a shared row-action control used by sidebars, dropdowns, and tabs.

  • The new tests cover activity adjacency and active, answered, and dismissed card boundaries.
  • Both previous spacing-test threads are resolved, and the added tests address their requested coverage.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Stream[Initial or tail SSE stream] --> Reader[Read SSE chunks]
  Reader -->|Event or keepalive| Reader
  Reader -->|45 seconds without a chunk| Cancel[Cancel silent reader]
  Cancel --> Reconnect[Resume from saved cursor]
Loading

Reviews (3) · Last reviewed commit: "chore(chat): cover interaction spacing b..."

@waleedlatif1
waleedlatif1 force-pushed the codex/chat-card-spacing branch from b264ab1 to 04ba348 Compare September 24, 2026 21:19
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 22 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit eac44eb into staging Sep 24, 2026
38 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/chat-card-spacing branch September 24, 2026 21:43

This branch was successfully deployed

1 active deployment
Preview — 04ba3480 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant