Skip to content

improvement(ui): align resource tab titles and actions with sidebar - #8269

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/resource-tab-title-space
Sep 24, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/resource-tab-title-space

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Let idle resource titles use the hidden close button's 24px slot without changing tab widths.
  • Use the sidebar's canonical OverflowText for clipping and tooltips, removing the tab-specific measurement logic.
  • Share one RowActions overlay across tabs, workspace and organization sidebars, and dropdown rows. Activity indicators yield to actions on hover/focus; touch and hybrid devices keep both accessible.

Type of Change

  • Improvement

Testing

  • Verified rendered before/after, stable tab widths, activity-to-X swapping, indicator click-through, short/pinned tabs, and keyboard closing in a local component preview.
  • 366 EMCN tests and 290 sidebar/resource tests passed, including tooltip and activity-slot coverage.
  • EMCN and app type-checks passed.
  • Lint, all 49 audits, API boundary validation, block registry, and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 24, 2026 9:06pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR lets idle tab titles use the hidden close-action space, adopts the shared overflow tooltip, and consolidates action overlays across tabs, sidebars, and dropdown rows. The latest revision adds an accessible activity label to background tabs.

Reviews (3) · Last reviewed commit: "fix(ui): announce background activity on..."

Comment thread packages/emcn/src/components/tab-strip/tab-strip.tsx Outdated
@waleedlatif1 waleedlatif1 changed the title improvement(ui): give idle resource tab titles more room improvement(ui): align resource tab titles and actions with sidebar Sep 24, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 13 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/tab-strip/tab-strip.tsx Outdated
Comment thread packages/emcn/src/components/tab-strip/tab-strip.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit df3b413 into staging Sep 24, 2026
37 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/resource-tab-title-space branch September 24, 2026 21:13

This branch was successfully deployed

1 active deployment
Preview — c54ffe56 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant