Finish cancelling stopped tools and preserve late-title replay

[Sg312]

Summary

Stopped responses now cancel tools waiting to start or awaiting approval as well as executing tools, so a stopped conversation cannot retain an actionable approval card after reload.

Server replay accepts a completion frame followed by a late title session event while retaining the matching terminal-run and gap-free-history requirements. Title generation itself is unchanged. This resolves the remaining findings from #8259.

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation
• Other

Testing

• All 61 persistence and Stop route regressions pass, covering pending/executing/approval tool states, immutability, completed tool preservation, a late title event, incomplete replay, and mismatched runs.
• App type checking and Biome pass.
• Greptile and Cubic finished reviewing the runtime changes. The sole finding, missing coverage for Stop marker creation, is fixed by testing every unfinished state with and without an existing marker. Updated CI must finish before staging merge.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 8:03pm UTC

[greptile-apps]

Confidence Score: 4/5

The PR appears safe to merge; restoring the no-marker regression case would improve coverage.

Findings

1.  Stopped marker coverage dropped ▶

Summary

The PR cancels pending and approval-waiting tools when persisting a stopped response, and allows server replay when a title event follows the completion frame.

• The replay still requires a terminal run for the chat and gap-free events.
• The revised tool-state tests drop direct coverage of adding a cancelled completion marker.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Stop request] --> B{Matching terminal run?}
  B -- No --> C[Do not persist server replay]
  B -- Yes --> D{Gap-free events with completion?}
  D -- No --> C
  D -- Yes --> E[Build assistant response]
  E --> F[Cancel unfinished tool states]
  F --> G[Persist stopped response]

Loading

_{Reviews (1) · Last reviewed commit: "Cancel waiting tools and retain complete..."}