Skip to content

feat(slack): expand workflow APIs and fix custom-app manifests - #8261

Merged
TheodoreSpeaks merged 9 commits into
stagingfrom
codex/slack-lists-sharing
Sep 24, 2026
Merged

TheodoreSpeaks merged 9 commits into
stagingfrom
codex/slack-lists-sharing

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds 43 normal workflow operations to the existing Slack block (95 total): List sharing, exports and bulk deletion; Canvas access; conversation membership; profile reads; files; reactions; pins; bookmarks; user groups; DND status reads; workspace metadata; emoji; and link unfurls. User-token-only search, profile updates, notification controls, Enterprise administration, and retired reminders APIs are excluded.
  • Keeps newly scoped actions on custom bots and leaves native Sim OAuth scopes unchanged. Removes the unused managed-user credential field and the newly added search/notification-write scope requests. Labels presence updates as Set Bot Presence. Custom manifests select all supported capabilities by default; existing installations must reinstall to grant new scopes.
  • Fixes Agent View manifests by removing incompatible legacy Assistant subscriptions. Native OAuth credentials retain Assistant event choices; custom bots use Agent View events. The picker resolves the active basic/manual credential, and deployment rejects saved custom-bot triggers using legacy Assistant events before webhook registration.
  • Restricts List/Canvas ownership to users, preserves existing channel/file output types, and validates provider inputs and pagination. Generated docs, the integration catalog, and tool metadata match the supported operations.

Type of Change

  • Feature
  • Bug fix

Testing

352 Slack operation, credential, and block tests pass after filtering user-only operations. All 404 repository script tests pass, including docs generation against the remaining supported Slack tools. All 42 remaining expansion methods document bot-token support in Slack's current API reference. All 49 repository audits, workspace lint, the staging-relative block-registry check, and docs-manifest check pass. Earlier validation also passed 155 deployment/ingress tests and the trigger-picker rendering suite. Local TypeScript checks were skipped as requested; CI performs compilation.

The expanded manifest previously reached Slack's app review step without the Agent View conflict; the draft was closed before creating or installing an app. The remaining expanded built-in operations are not deployed or live-tested yet.

Base and intended first deployment target: staging. Do not merge or enable auto-merge without explicit approval for the current changes. Production deployment requires separate authorization.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 24, 2026 10:59pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge based on this review; the changed regression test matches the generated schema.

Summary

The PR expands Slack workflow operations and custom-bot capabilities, updates credential and trigger handling, and aligns generated metadata and documentation. Since the previous review, the only change replaces a Slack Search output assertion with Slack Files output assertions.

  • The replacement assertions match the generated output schema.
  • All previous Greptile threads are resolved; no new actionable issue was established.

Reviews (8) · Last reviewed commit: "test(slack): use supported operation in ..."

Comment thread apps/sim/blocks/blocks/slack.ts Outdated
Comment thread apps/sim/blocks/blocks/slack.ts
@TheodoreSpeaks TheodoreSpeaks changed the title feat(slack): add Share List operation feat(slack): add List sharing and fix Agent View manifests Sep 24, 2026
@TheodoreSpeaks TheodoreSpeaks changed the title feat(slack): add List sharing and fix Agent View manifests feat(slack): expand workflow APIs and fix custom-app manifests Sep 24, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 79 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/sim/tools/slack/set_user_presence.ts
Comment thread apps/sim/tools/slack/list_pins.ts
Comment thread apps/sim/triggers/slack/capabilities.ts
Comment thread apps/sim/tools/slack_lists/download_get.ts
Comment thread apps/sim/tools/slack/search_messages.ts Outdated
Comment thread apps/sim/tools/slack/get_file_info.ts
Comment thread apps/sim/lib/credential-groups/slack-managed-user-scopes.ts
Comment thread scripts/generate-docs.ts Outdated
Comment thread apps/sim/tools/slack/fixtures/workflow-api-responses.json
Comment thread apps/sim/tools/slack/list_user_group_members.ts Outdated
Comment thread apps/sim/blocks/blocks/slack-workflow-operations.ts
Comment thread packages/deployment-config/src/integrations.json
@greptile-apps

This comment has been minimized.

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 81 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/tools/slack/update_user_group.ts
Comment thread apps/sim/tools/slack/search_all.ts Outdated
Comment thread apps/sim/blocks/blocks/slack.ts
Comment thread apps/sim/triggers/slack/shared.ts Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 86 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/triggers/slack/shared.ts
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 88 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 81 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 81 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 0ede40b into staging Sep 24, 2026
35 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/slack-lists-sharing branch September 24, 2026 23:16

This branch was successfully deployed

1 active deployment
Preview — c7cbaa14 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant