improvement(search): search several GitHub and GitLab kinds per account in one call and hide recovered search failures - #8258
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
4792717 to
3a0b324
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…nt in one call and hide recovered search failures
…y retried search failures
3a0b324 to
87dcc28
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
search_workspacecall send one native query per GitHub or GitLab kind for the same account (e.g. issues and commits together). Before, any two queries for the same account were rejected, so the model burned a round trip and a failed call on a common request.scopeper request, so each kind is its own provider search. The rule is now one query per account and kind. A query without a kind, or two of the same kind, still conflicts, and so do queries for providers that don't usekind.kind) andnextCursor, so paging stays per query./user/repos, GitLab/projects) is memoized on the session client, so several kinds share one listing. Provider requests are the same as the two separate calls the model would otherwise make.search_workspacecall that errored when a later call follows it in the same activity group, so the retry takes its place. The last call always stays, so a run where every search failed still shows its outcome.Type of Change
Testing
retry-afterhandling, secondary limits. Also checked against the GitLab search API (one scope per request)bun run lint,check:audits, block registry, docs manifest, type-check and the search, contracts, mothership and home UI suites passChecklist