fix(slack-search): stream task progress in plan mode - #8219
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sim Search currently displays Slack search/read progress as individual timeline cards. Set its
chat.startStreamdisplay mode toplanso those task updates appear together in a plan block, as described in Slack's API reference.Update existing tests for streams starting with task progress or public answer text. Task IDs, completion/error updates, citations, thread identity, cancellation cleanup, and private-text filtering retain their existing behavior. Workflow Slack streaming keeps its configurable display mode.
The source-setup regression test now waits for integration selection after the asynchronous URL update before asserting navigation order. This fixes a timing failure reproduced in the full test file without changing application behavior.
Type of Change
Testing
Local checks passed:
apps/sim:bunx vitest run 'app/o/[organizationId]/settings/components/integrations' lib/slack-search lib/knowledge/application/slack-search lib/webhooks/slack-agent-api.test.ts lib/webhooks/slack-execution-stream.test.ts lib/webhooks/slack-stream-config.test.ts --maxWorkers=4— 642 tests across 40 files.apps/sim:bun run type-check.bun run check:api-validation.git diff --check.No live Slack messages were sent; rendering has not been manually verified in Slack.
Deployment
Base:
staging. Merging triggers the staging deployment pipeline via ECR tag promotion. Production uses a separatemainpush andlatesttag promotion. This PR is prepared for review only; merge and production release each require explicit approval.