Skip to content

feat(jev): add TypeSafe decision integration - #8103

Open
waleedlatif1 wants to merge 5 commits into
stagingfrom
codex/jev-integration
Open

waleedlatif1 wants to merge 5 commits into
stagingfrom
codex/jev-integration

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add native Jev Choice, Score, Noul, and batch evaluation tools with a TypeSafe API-key block. Jev uses the System One decision API, so it is exposed as an integration rather than a chat model.
  • Validate native requests and responses, project model-bound secrets through the shared executor, and retain probabilities, confidence, and token usage.
  • Add the official TypeSafe SVG and brand color, JSON-generation helpers, workflow templates, structured suggested skills, and generated catalog/docs metadata.

Type of Change

  • New feature

Testing

  • 56 Vitest tests pass across Jev and the shared wand sanitizer, covering all four operations, workflow execution, invalid inputs/responses, exact batch answer IDs/types, and resolved-secret projection.
  • App type-check, lint, lint:check, all 47 audits, API validation, block registry, canvas sentences, and docs manifest checks pass.
  • Visually checked the official SVG in light, dark, and brand-tile contexts.
  • 13 live API checks pass through the shared tool executor and workflow block handler: all four operations, structured state/instructions/rubrics, object and serialized batches, pinned/latest/preview models, and invalid-key handling.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 4:17pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable new defects or outstanding previous findings remain.

Summary

Adds TypeSafe AI’s Jev as a native decision integration.

  • Provides Choice, Score, Noul, and batch Evaluate tools with validated request and response contracts.
  • Projects model-bound secrets through the shared executor and retains probabilities, confidence, model, and token-usage metadata.
  • Registers the Jev block, TypeSafe branding, documentation, generated tool metadata, workflow templates, and suggested skills.
  • The changes since the previous review refine the Noul canvas sentence; both previously reported issues are resolved.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  W[Workflow Jev block] --> O{Selected operation}
  O -->|Choice| C[Choice request]
  O -->|Score| S[Score request]
  O -->|Noul| N[Yes/no request]
  O -->|Evaluate| E[Batch questions]
  C --> P[Validate and build System One payload]
  S --> P
  N --> P
  E --> P
  P --> T[TypeSafe System One API]
  T --> V[Validate response shape]
  V --> R[Workflow outputs: decision, probabilities, confidence, model, usage]
Loading

Reviews (5) · Last reviewed commit: "fix(jev): clarify empty Noul canvas sent..."

Comment thread apps/sim/tools/jev/evaluate.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/tools/jev/choice.ts
Comment thread apps/sim/tools/jev/evaluate.ts Outdated
Comment thread apps/sim/tools/jev/shared.ts
Comment thread apps/sim/tools/jev/shared.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 25 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jev.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jev.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 25 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jev.ts

This branch was previously deployed

1 inactive deployment
Preview b3fc80d7 Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant