Skip to content

improvement(ui): use chips for table job actions - #8082

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-table-job-actions
Open

BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-table-job-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use Chip for the table import-status menu trigger and Stop all action.
  • Preserve job status colors, running animation, counts, disabled states and cancellation behavior; adopt shared chip height and typography.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 12:58am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because both replacements preserve native button, disabled, ref-forwarding, and dropdown-trigger behavior.

Summary

This PR replaces two table-job Button controls with shared Chip controls while retaining their existing interactions and state.

  • Converts the Stop-all action to an actionable, disabled-aware Chip.
  • Converts the import-progress dropdown trigger to a Chip while preserving aggregate status iconography and counts.
  • Uses the Chip component’s shared height, typography, icon spacing, and native-button behavior.

Reviews (1) · Last reviewed commit: "improvement(ui): use chips for table job..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Table job/import actions reuse Chip with the existing spinner, error/completion icon and progress count. Running, failed and complete examples are shown.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 61bac52e7c.

Before and after: light jobs running

Additional theme/state comparisons

Before and after: dark jobs running

Before and after: light jobs failed

Before and after: dark jobs complete

This branch was previously deployed

1 inactive deployment
Preview 61bac52e Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant