Skip to content

improvement(ui): use chip fields in workflow search and replace - #8076

Open
BillLeoutsakosvl346 wants to merge 3 commits into
codex/emcn-consolidationfrom
codex/control-fix-search-replace-fields
Open

BillLeoutsakosvl346 wants to merge 3 commits into
codex/emcn-consolidationfrom
codex/control-fix-search-replace-fields

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use ChipInput for workflow search and text replacement, and ChipCombobox for resource replacement.
  • Keep input refs, keyboard handling, search options and replacement callbacks; adopt standard chip corners, field height and theme-aware surface.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • External source comparison confirms caller logic and content are unchanged.
  • Before/after browser fixtures cover the changed component's styling and interactions. Search-and-replace intentionally adopts chip field styling. These are isolated fixtures, not full authenticated product flows.
  • Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:42pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule issues were identified.

Summary

This PR adopts shared chip-styled controls across workflow search and replacement, execution refresh, and chat error recovery while preserving the existing interaction callbacks and state.

  • Uses ChipInput for workflow search and text replacement.
  • Uses ChipCombobox for compatible resource replacement.
  • Uses Chip for replacement, refresh, and recovery actions.
  • Applies the shared centered-alignment API instead of overriding chip typography.

Reviews (3) · Last reviewed commit: "fix(ui): use shared centered chip conten..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Search fields reuse ChipInput: 34px → 30px high, 4px → 8px corners, shared text color and dark fill. Existing editing logic is retained.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 39573f375f.

Before and after: light search field

Additional theme/state comparisons

Before and after: dark search field

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-search-replace-fields branch from 27d0467 to f9e4092 Compare September 22, 2026 20:21
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/app/(interfaces)/chat/components/error-state/error-state.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from codex/emcn-consolidation to codex/overrides-chip-sizing September 22, 2026 20:42
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-search-replace-fields branch from f9e4092 to d6cf7c1 Compare September 22, 2026 20:42
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Base automatically changed from codex/overrides-chip-sizing to codex/emcn-consolidation September 23, 2026 02:11

This branch was previously deployed

1 inactive deployment
Preview d6cf7c1a Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant