Skip to content

improvement(ui): share workflow preview actions - #8065

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-overlay-action-buttonsfrom
codex/control-fix-workflow-preview-actions
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/control-fix-overlay-action-buttonsfrom
codex/control-fix-workflow-preview-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Share the three embedded workflow preview actions through one product component using EMCN Button and Tooltip.
  • Preserve the 24px geometry, solid surface, accessible labels, icons and open/expand handlers.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • External source comparison confirms caller logic and content are unchanged.
  • Original and extracted components have matching computed styles in light/dark browser fixtures; keyboard, disabled and expansion behavior checked. These are isolated fixtures, not full authenticated product flows.
  • Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:28pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the refactor preserves the existing preview-action behavior and no actionable regressions remain.

Summary

This PR extracts the repeated embedded-workflow preview action into a shared WorkflowPreviewAction component.

  • Preserves the existing open and expand handlers at all three call sites.
  • Centralizes the tooltip, accessible label, fixed button behavior, positioning, and visual treatment.
  • The previously reported props-interface and fixed-button-type concerns are resolved; the transition concern was correctly conceded because the underlying EMCN Button already supplies it.

Reviews (5) · Last reviewed commit: "improvement(ui): share workflow preview ..."

Comment thread apps/sim/components/workflow/workflow-preview-action.tsx Outdated
Comment thread apps/sim/components/workflow/workflow-preview-action.tsx Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Workflow preview open/expand actions share WorkflowPreviewAction while retaining their existing small bordered button treatment.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: b779967927.

Before and after: 8065

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-field-disclosures branch from 2d56098 to f472cbb Compare September 22, 2026 19:57
@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from codex/control-fix-field-disclosures to codex/control-fix-overlay-action-buttons September 22, 2026 20:00
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-workflow-preview-actions branch from b779967 to 34cc3c8 Compare September 22, 2026 20:00
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/components/workflow/workflow-preview-action.tsx
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile Please re-review the current head. The inline response explains the shared definition and the authorized design-system scope.

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-overlay-action-buttons branch from e5c205a to 9c2953d Compare September 22, 2026 20:28
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-workflow-preview-actions branch from 34cc3c8 to 3e6c870 Compare September 22, 2026 20:28
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview 3e6c8707 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant