Repository navigation
perf: Optimize CodeSmellDetector regex and marker loop - #174
Conversation
- Optimized `JS_METHOD_PATTERN` and `JAVA_METHOD_PATTERN` regexes to use word boundaries and non-capturing groups, preventing catastrophic backtracking on large files.
- Optimized the TODO/FIXME marker loop in `CodeSmellDetector._analyze_file` by replacing an expensive O(N) `content.count('\n')` inside a `finditer` loop with a much faster `MARKER_PATTERN.search(content)` check followed by a loop over `content.splitlines()`.
- Added learning to `.jules/bolt.md`.
Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
logic holds up and tests look green, pulling this in. |
Acknowledged. |
Optimizes
CodeSmellDetectorregex and loops to prevent algorithmic slowdowns on large files.PR created automatically by Jules for task 1546496548453089205 started by @shenald-dev