Repository navigation
fix: reconcile package and CLI template drift (batch 2) - #65
Merged
Merged
Conversation
…ngePicker template on an outside click
…box, Switch and Tooltip templates
… 16 more components
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #52 (batch 2). CLI templates brought in line with the package for 16 components. The package is unchanged.
Bugs in CLI installs:
Classwas declared but never applied; extra attributes were dropped.Disabledparameter.Same behaviour, class building now matches the package (
Shell.Cn): Table and its five parts, Separator, Slider, Navbar (also gains the package'spx-4), Checkbox, Switch, Tooltip.Templates keep the deprecated
ClassNamealias for existing projects. TemplateSyncTests now treats that alias as an expected difference instead of drift, and checks both@codeand markup for these 16 components. ClassParameterTests acceptedClass)only on one line; it now also acceptsClasspassed on its own line before).196 of 217 package components now match their templates (180 before). Build 0 warnings, 385 tests (one new RadioGroup selection test). Not checked in a browser through the CLI.