Skip to content

fix: reconcile package and CLI template drift (batch 1) - #63

Merged
Shewart merged 8 commits into
mainfrom
fix/template-drift-1
Oct 17, 2026
Merged

Shewart merged 8 commits into
mainfrom
fix/template-drift-1

Conversation

@Shewart

@Shewart Shewart commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Part of #52. Eight components where one copy was plainly wrong or behind the other.

Package:

  • Label: For was accepted but never rendered as for.
  • FileUpload: the icon needed the Material Symbols font, which the package does not ship. Now an inline SVG, as in the CLI template.
  • Sheet: the close button was missing when only Description was set.
  • Sheet, Drawer, SheetContent, DrawerContent: clicks inside the panel reached parent click handlers.

CLI templates:

  • CarouselItem: divide by zero when TotalSlides is 0.
  • SidebarMenuButton: collapsed-icon styling from the package.
  • Menubar: border follows the theme colour.
  • ThemeToggle: class building matches the package.

Also adds a markup comparison to TemplateSyncTests for these components (the existing test only compares @code blocks), regenerates the class safelist, and corrects the roadmap: the Select, ContextMenu, NavigationMenu and Carousel parts already have CLI templates.

180 of 217 package components now match their templates. Build has 0 warnings, 349 tests pass. Not checked in a browser.

Copilot AI balanced review requested due to automatic review settings October 17, 2026 20:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Shewart
Shewart merged commit 4f7e15e into main Oct 17, 2026
1 check passed
@Shewart
Shewart deleted the fix/template-drift-1 branch October 17, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants