Repository navigation
fix(ticket-185): skip detected setup.py with computed version as a version source - #188
Open
tom-sapletta-com wants to merge 1 commit into
Open
tom-sapletta-com wants to merge 1 commit into
tom-sapletta-com wants to merge 1 commit into
Conversation
…rsion source [ticket-185] A setup.py that reads its version from VERSION or pyproject.toml has no literal to read or bump; treating every root-level file as primary made 'goal -a' fail with 'setup.py:version: selector version was not found'. A configured setup.py:version source without a literal still fails. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
goal -a --bump patchin semcod/fixos stopped with:fixos's
setup.pyreads its version fromVERSION(single source of truth since fixos ticket-066/068).collect_version_sourcestreats every root-level detected file as a primary source, so a computedversion=made the release fail even thoughgoal.yamlonly configuresVERSIONandpyproject.toml:version.Fix
Skip an auto-detected
setup.pywith no version literal. Asetup.py:versionsource configured ingoal.yamlstill fails closed.Validation
VersionStateError.pytest tests/test_version_state.py tests/test_version_sync.py→ 57 passed; governance GOV-PASS.goal -a --bump patchin semcod/fixos with this branch passes the version stage.🤖 Generated with Claude Code