Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:checkedcurrently compares@typewith the lowercase stringscheckboxandradio. As a result, a checked input such as<input type="CHECKBOX" checked>is omitted, even though HTML enumerated attribute keywords are ASCII case-insensitive.Normalize the input type with XPath's ASCII-only
translate()before comparing it. Regression coverage exercises lowercase, uppercase and mixed-case types in both HTML and XHTML modes, and preserves unchecked inputs, unrelated or missing types, non-ASCII lookalikes, selected options and GenericTranslator behavior.Validation on Python 3.12:
pytest --cov=cssselect --cov-report=term-missing cssselect tests docs: 45 passed, 1 xfailed.The case-insensitive keyword rule is defined in the HTML enumerated attributes specification.