Repository navigation
Declare the position of TwoFactorAccessListener with #[FirewallListenerOrder] - #325
Merged
Merged
Conversation
Owner
|
Will |
Contributor
Author
|
Nope, it's still the main mechanism, the before/after is extra rules on top. |
Owner
|
@nicolas-grekas Would you please rebase and re-target the PR to the sf-8.2 branch, which has a build against Symfony 8.2 development versions configured. Thanks! |
nicolas-grekas
force-pushed
the
firewall-listener-order
branch
from
October 10, 2026 16:17
6db9c46 to
907c92c
Compare
Contributor
Author
|
Done! |
Owner
|
Excellent, thanks! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Symfony 8.2 adds
#[FirewallListenerOrder](symfony/symfony#66718) to declare the firewall listeners a listener runs before or after. This turns the comment ingetPriority()into a check: the priority stays -191 so nothing moves, but the container will fail to compile if Symfony's priorities ever stop matching it.Older Symfony versions ignore the attribute.