Remove Orbit remote management - #6320
Draft
francoisferrand wants to merge 1 commit into
Draft
francoisferrand wants to merge 1 commit into
francoisferrand wants to merge 1 commit into
Conversation
The Pensieve/Orbit remote-management flow (polling and pushing the configuration overlay from the PENSIEVE bucket, decrypting service account secrets, rebuilding location constraints from the overlay) has been dead for a long time: zenko-operator sets REMOTE_MANAGEMENT_DISABLE and renders locationConfig.json itself, Orbit / Zenko 1.x are no longer supported, and S3C never used it. Keeping it around only forces Arsenal to keep exporting the pensieve credential utils and patchLocations. This drops everything that only existed for it: config overlay handling, the management agent and secure channel proxy, the Zenko instance-id user metadata tagging, the overlayVersion and managementAgent config, and the node-forge dependency. The /_/report endpoint no longer returns a `config` object as it only carried the overlay version. The metrics push client (bin/metrics_server.js and its websocket client in lib/management) is kept, reduced to answering metrics requests: zenko-operator still deploys cloudserver-metrics-server. The Config setters (setLocationConstraints, setAuthDataAccounts, ...) and the location-constraints-update event are kept: they are still used by the location config reload path, bucketPut, the data wrapper and routeBackbeat. The management config unit test happened to reset config.locationConstraints between suites, which was masking a leak in objectReplicationMD.js (it replaced the real awsbackend location and then deleted it). That test now restores the original entries. Issue: CLDSRV-1013
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| itemCounts: getObjectCount, | ||
| crrStats: crrStatsObj, | ||
| repStatus: results.getReplicationStates, | ||
| config: cleanup(config), |
There was a problem hiding this comment.
tests/functional/report/checkRoutes.js still has should contain config, which fails now that /_/report has no config. The three should remove ... from config tests also become no-ops. Remove these tests in this PR (they run via yarn ft_management).
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 4 files with indirect coverage changes @@ Coverage Diff @@
## development/9.5 #6320 +/- ##
===================================================
+ Coverage 86.54% 87.68% +1.13%
===================================================
Files 213 206 -7
Lines 14606 14195 -411
===================================================
- Hits 12641 12447 -194
+ Misses 1965 1748 -217
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pensieve/Orbit remote-management flow (poll/push of the config overlay stored in the
PENSIEVEbucket, decryption of service account secrets, rebuilding location constraints from the overlay) has been dead for a long time: zenko-operator setsREMOTE_MANAGEMENT_DISABLEand renderslocationConfig.jsonitself, Orbit / Zenko 1.x are unsupported, and S3C never used it. Removing it lets Arsenal drop thepensievecredential utils andpatchLocationsexports (ARSN-653).What goes away: config overlay handling, the management agent, the secure channel proxy, the Zenko instance-id user metadata tagging, the
overlayVersion/managementAgentconfig, andnode-forge./_/reportno longer returns aconfigobject, since it only carried the overlay version.What stays:
bin/metrics_server.jsand a metrics-only websocket client inlib/management, because zenko-operator still deployscloudserver-metrics-server.location-constraints-updateevent, which the location config reload path, bucketPut, the data wrapper and routeBackbeat still use.Related: BB-896 (Backbeat), ZKOP-617 (removes the operator's secure channel proxy reconciler).
Issue: CLDSRV-1013