Count non-localized versions when deleting a bucket - #6313
Merged
bert-e merged 2 commits intoSep 30, 2026
Merged
Conversation
Contributor
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 5 files with indirect coverage changes @@ Coverage Diff @@
## development/9.5 #6313 +/- ##
===================================================
+ Coverage 86.50% 86.60% +0.10%
===================================================
Files 213 213
Lines 14610 14610
===================================================
+ Hits 12638 12653 +15
+ Misses 1972 1957 -15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
SylvainSenechal
marked this pull request as ready for review
September 29, 2026 17:21
francoisferrand
approved these changes
Sep 29, 2026
maeldonn
approved these changes
Sep 30, 2026
|
|
||
| it('should count the non-localized versions when checking the bucket is empty', done => { | ||
| const listObject = sinon.spy(metadata, 'listObject'); | ||
| bucketPut(authInfo, testRequest, log, () => { |
Contributor
There was a problem hiding this comment.
Could you promisify bucketPut ?
SylvainSenechal
force-pushed
the
improvement/CLDSRV-1014/clean-view-delete-bucket
branch
from
September 30, 2026 10:08
8d8cdf2 to
a73039b
Compare
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue CLDSRV-1014. Goodbye sylvainsenechal. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRV-1014
With recent changes regarding clean view, there was a risk that we could delete a non empty bucket if it only had non localized version.
Uunlikely to be super useful since I doubt clients would delete bucket on their disaster recovery site, and it could be weird to get an error "can't delete bucket, still have objects" while not being able to see these objects on the frontend, but still probably should do this pr or do something about it