Integrate Pull Replication's clean read into cloudserver - #6295
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| "@opentelemetry/instrumentation-mongodb": "~0.69.0", | ||
| "@smithy/node-http-handler": "^3.0.0", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.5.15", | ||
| "arsenal": "git+https://github.com/scality/arsenal#baa462fc", |
There was a problem hiding this comment.
Arsenal is pinned to a commit hash (baa462fc) instead of a release tag. Per project conventions, git-based deps must be pinned to a tag (e.g. #8.5.16).
| "arsenal": "git+https://github.com/scality/arsenal#baa462fc", | |
| "arsenal": "git+https://github.com/scality/arsenal#8.5.16", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## development/9.5 #6295 +/- ##
===================================================
- Coverage 86.54% 86.50% -0.05%
===================================================
Files 213 213
Lines 14606 14610 +4
===================================================
- Hits 12641 12638 -3
- Misses 1965 1972 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
744f623 to
20b9653
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
20b9653 to
03f2287
Compare
| "@opentelemetry/instrumentation-mongodb": "~0.69.0", | ||
| "@smithy/node-http-handler": "^3.0.0", | ||
| "arsenal": "git+https://github.com/scality/arsenal#8.5.15", | ||
| "arsenal": "git+https://github.com/scality/arsenal#c6745fd3", |
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/CLDSRV-957/clean-read-config && \
git merge origin/development/9.5Resolve merge conflicts and commit git push origin HEAD:improvement/CLDSRV-957/clean-read-config |
francoisferrand
left a comment
francoisferrand
left a comment
There was a problem hiding this comment.
Looks good, to be confirmed/tested.
Maybe should wait until the prettier PR is merged, to avoid conflict?
| instanceId: config.instanceId, | ||
| config, | ||
| locations: config.locationConstraints, | ||
| hideNonLocalizedVersions: true, |
There was a problem hiding this comment.
should this be the default in MetadataWrapper (in arsenal) instead?
There was a problem hiding this comment.
I think its weird to have arsenal use true because we still need cloudserver to pass the config location constraints which will become some kind of flag itself
|
Waiting on Arsenal |
03f2287 to
94a242b
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-957. Goodbye sylvainsenechal. |
4 participants
Cloudserver will now apply the clean read filter to all apis and deployments (internal and external cloudserver) : It will not see objects whose data is located on a different location.
One exemption : the get backbeat metadata api, which queries objects with specific versions. If it applied the clean read filter, we would end up with the data mover getting noSuchKey for objects where it's trying to move their locations.
The exemption is safe to do even though the api is used for by other components than the data mover, because get metadata queries a specific versionID, and that version ID is discovered through a listing, but the listing api applies the clean read filters anyways so there is no ris of querying non localized objects.
Issue: CLDSRV-957