Repository navigation
Keep a Unix socket open after reading end of stream - #99
Merged
Merged
Conversation
When a read on a Unix socket reached end of stream, the socket closed itself completely, and anything written afterwards was silently dropped. This breaks a common pattern: a client sends a request, calls shutdownOutput() to signal that the request is complete, and waits for the response. The server reads the request to the end, and then can't send the response. Now end of stream only means that the other side has stopped sending. The socket stays open until close() is called, and writing to a closed socket throws SocketException instead of doing nothing. Behavior change: a socket that is read to the end but never closed now keeps its file descriptor until it is garbage collected. Sockets should be closed, as with any java.net.Socket. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a read on a Unix socket reached end of stream, the socket closed itself completely, and anything written afterwards was silently dropped. This breaks a common pattern: a client sends a request, calls
shutdownOutput()to signal that the request is complete, and waits for the response. The server reads the request to the end, and then can't send the response.Now end of stream only means that the other side has stopped sending. The socket stays open until
close()is called, and writing to a closed socket throwsSocketExceptioninstead of doing nothing.Behavior change: a socket that is read to the end but never closed now keeps its file descriptor until it is garbage collected. Sockets should be closed, as with any
java.net.Socket.