Repository navigation
Fix ByteBuffer handling in ForwardingSocketChannel - #96
Merged
Merged
Conversation
ForwardingSocketChannel makes a socket usable as a SocketChannel. Windows always uses it, and Unix uses it on Java versions before 17. It ignored the position and limit of the ByteBuffers passed to it: - read threw IndexOutOfBoundsException at end of stream instead of returning -1, and could put the data at the wrong place in the buffer. - write sent the buffer's whole backing array and didn't advance its position, so a loop that writes until the buffer is empty never ended. - The read and write variants that take several buffers only used the first one. Now read and write respect the buffer's position and limit, and the variants with several buffers use all of them. Also, getRemoteAddress returned the local address instead of the remote one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForwardingSocketChannelmakes a socket usable as aSocketChannel. Windows always uses it, and Unix uses it on Java versions before 17. It ignored the position and limit of theByteBufferspassed to it:IndexOutOfBoundsExceptionat end of stream instead of returning-1, and could put the data at the wrong place in the buffer.Now read and write respect the buffer's position and limit, and the variants with several buffers use all of them. Also,
getRemoteAddressreturned the local address instead of the remote one.