Repository navigation
fix(deps): run the cli tests against @sasjs/lint 4.6.1 - #1503
Conversation
There was a problem hiding this comment.
Reviewed the full diff: package.json and package-lock.json raise @sasjs/lint from ^4.4.0 to ^4.6.1 in devDependencies and peerDependencies; no source changes. CI status is pending at this head, so this is a diff-only review.
- package.json:127 - raising the peerDependencies floor to ^4.6.1 breaks every consumer still on lint 4.4.x/4.5.x: npm 7+ fails to resolve the tree instead of warning the way it does below the floor. That is a breaking change to the peer contract, which
fix(deps)understates. Note it in the release notes, or leave the peer floor at ^4.4.0 if the code does not actually require the newer API. - package.json:97 - the entry keeps its caret range while the surrounding dependencies are pinned exactly, and .npmrc sets save-exact. Pin @sasjs/lint to 4.6.1 so installs stay reproducible and a future 4.x cannot drift in under the released floor.
2 findings above for review.
The devDependency takes the version the commands run against, and every other devDependency in this file is pinned exactly (`save-exact` in .npmrc matches), so lint moves 4.4.0 -> 4.6.1 as an exact pin. That is the release whose quoted-string scanning and 3-character name floor change what `sasjs lint` reports, and it is what the lint command's tests now resolve. The peer range stays ^4.4.0. Raising it would fail to resolve for every consumer still on 4.4.x or 4.5.x - npm 7+ reports ERESOLVE below the floor rather than warning - and the CLI uses no API that 4.6.1 added: the difference is what lint reports, which is lint's own release note. A range states compatibility, an exact value states what was tested, so the two carry different versions on purpose. Verified: lockfile resolves one copy at 4.6.1, `tsc --noEmit` clean, `npx jest src/commands/lint` 13/13.
73b1def to
73f2be4
Compare
|
Both taken, and the audit failure was not this diff. Peer floor - reverted to devDependency - now exactly Title changed to match what the diff now is ( The red |
There was a problem hiding this comment.
Reviewed the full base...head diff - a devDependency bump (@sasjs/lint ^4.4.0 -> 4.6.1) with the matching package-lock.json entry. The range is now pinned, which is the direction the hardening rule wants; no source changes ride along.
- CI reports no check contexts yet at this head (pending). Confirm the lint-version bump is green before merging, since the change exists only to move the test toolchain.
No blocking issues.
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from c474074 |
The devDependency is what the commands run against in this tree, and every other devDependency here is pinned exactly (
save-exactmatches), so lint goes 4.4.0 -> 4.6.1 as an exact pin - the release whose quoted-string scanning and 3-character name floor change whatsasjs lintreports.The peer range stays
^4.4.0: raising it fails to resolve for every consumer still on 4.4.x or 4.5.x (npm 7+ reports ERESOLVE below the floor rather than warning), and the CLI uses no API that 4.6.1 added - the difference is what lint reports, which belongs in lint's release note. A range states compatibility, an exact value states what was tested, so the two carry different versions on purpose.Lockfile resolves one copy at 4.6.1;
tsc --noEmitclean;npx jest src/commands/lint13/13.The
Audit the release toolchainfailure on the previous head is unrelated - three undici advisories published since the last green run, reproduced onmainat 62fd077 and fixed in #1504.