Conversation
lukasedw
force-pushed
the
top-layer-ignores-ancestor-opacity
branch
from
September 29, 2026 00:33
aba98ed to
ff99f3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isVisiblewalks every ancestor of a node and reports hidden if any of them hasdisplay: none,visibility: hiddenoropacity: 0. Apopoveror a modal<dialog>renders in the top layer once shown, so it's actually on screen even under anopacity: 0ancestor, butisVisiblestill reports it hidden:Fix
Ancestor opacity stops applying past an open popover or a modal dialog, since they render in the top layer; the
displayandvisibilitychecks are unchanged.Testing
Three specs under
Node#visible. The first two fail onmain; the third is a guard that already passes. Suite and rubocop pass.