Add zizmor and fix its findings - #80
Merged
Merged
Conversation
Adds a zizmor workflow that calls rubyatscale/shared-config's reusable zizmor.yml, and fixes what zizmor 1.30.1 reports here so it starts clean. In build.yml, checkout moves to v7.0.1 and setup-ruby to v1.327.0, both pinned to commit SHAs, and checkout sets persist-credentials: false. The gem install bundler step goes: setup-ruby already installs the Bundler version from Gemfile.lock. In push_gem.yml, harden-runner moves from v2.11.0, which has known vulnerabilities, to v2.21.1. The release job no longer restores the bundler cache, which other workflows can write; it runs bundle install instead. Its checkout sets persist-credentials: false, since release-gem v1.1.0 points the remote at a token URL itself, and the release-gem comment now names v1.1.0 instead of v1. Dependabot's bundler entry gets a 7-day cooldown, and a github-actions entry keeps the new pins current.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/zizmor.yml, a caller ofrubyatscale/shared-config/.github/workflows/zizmor.yml@main(rubyatscale/shared-config#32), and fixes everything zizmor 1.30.1 reports here so the new check starts clean. It's the same cleanup the other rubyatscale repos got this week.advanced-security: true, so results go to the Security tab. The caller grantscontents: readandsecurity-events: write.build.yml:actions/checkoutv3 → v7.0.1 andruby/setup-rubyv1 → v1.327.0, both pinned to commit SHAs.persist-credentials: falseon the checkout.gem install bundlerstep is gone (zizmoradhoc-packages). setup-ruby already installs the Bundler version fromGemfile.lock.push_gem.yml:step-security/harden-runnerv2.11.0 → v2.21.1, since v2.11.0 has known vulnerabilities (zizmorknown-vulnerable-actions).cache-poisoning). It runsbundle installinstead.persist-credentials: falseon the checkout. The pinnedrubygems/release-gem(v1.1.0) points the git remote at a token URL itself beforerake release, so the tag push doesn't need the checkout's credential.release-gempin keeps its SHA, but its comment saidv1, which now points elsewhere. It now saysv1.1.0(zizmorref-version-mismatch).cooldownon the bundler entry, plus agithub-actionsentry to keep the new pins current.This touches
build.yml,push_gem.ymlanddependabot.yml, which #78 also changes, so whichever merges second will need a small rebase.Test plan
zizmor / zizmorand the existing checks pass on this PR.