Fix the stale checkout version comment in cd.yml - #33
Merged
Merged
Conversation
Dependabot bumped the checkout SHA to v7.0.1 in #30 but left the comment at v7.0.0, most likely because the zizmor ignore followed it on the same line. The ignore moves to the with: line, next to an explicit persist-credentials: true, so the version comment stands alone and Dependabot can update it. Checkout already persists credentials by default, so behavior doesn't change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd.yml's checkout is pinned to v7.0.1's SHA, but its comment still said# v7.0.0. Dependabot bumped the SHA in #30 and left the comment, most likely because the# zizmor: ignore[artipacked]came after it on the same line. zizmor'sref-version-mismatchaudit didn't catch it either.The comment now says
# v7.0.1. The ignore moves to thewith:line, next to an explicitpersist-credentials: true, so the version comment stands alone where Dependabot can update it. Checkout persists credentials by default, so behavior doesn't change. The comment block above the step already explains why the credential has to persist.Test plan
artipackedignore still applies from thewith:line.$/errors, Support the new$/self-repositoryuses:syntax rhysd/actionlint#711).